Implement Tree.RemoveStyle #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhugh
reviewed
Apr 16, 2024
Comment on lines
+34
to
+59
| return when { | ||
| attributes?.isNotEmpty() == true -> { | ||
| tree.style(fromPos to toPos, attributes, executedAt).map { | ||
| TreeStyleOpInfo( | ||
| it.from, | ||
| it.to, | ||
| it.fromPath, | ||
| it.attributes.orEmpty(), | ||
| path = root.createPath(parentCreatedAt), | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| attributesToRemove?.isNotEmpty() == true -> { | ||
| tree.removeStyle(fromPos to toPos, attributesToRemove, executedAt).map { | ||
| TreeStyleOpInfo( | ||
| it.from, | ||
| it.to, | ||
| it.fromPath, | ||
| attributesToRemove = it.attributesToRemove.orEmpty(), | ||
| path = root.createPath(parentCreatedAt), | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| else -> emptyList() |
There was a problem hiding this comment.
is it assured that only one of attributes or attributesToRemove will be set?
There was a problem hiding this comment.
In the current interface, style() can only set attributes, and removeStyle() can only set attributesToRemove. So I think it is logically assured that only one of them will be set.
skhugh
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Implement
JsonTree.removeStyle().Any background context you want to provide?
What are the relevant tickets?
Checklist