Update CI Workflows to also test Xcode 14.3.1 #1378
Conversation
liamnichols
force-pushed
the
ln/ci
branch
2 times, most recently
from
41be4d2
to
a03254c
Compare
| IPHONEOS_DEPLOYMENT_TARGET=14.0 | ||
| MACOSX_DEPLOYMENT_TARGET=10.15 | ||
| TVOS_DEPLOYMENT_TARGET=14.0 | ||
| WATCHOS_DEPLOYMENT_TARGET=7.0 |
There was a problem hiding this comment.
Xcode 14 stopped setting default values for these settings which usually only results in warnings, but in this instance the builds were failing entirely. I came to this solution from https://stackoverflow.com/a/75729977
| env: | ||
| DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer | ||
| steps: | ||
| - uses: actions/checkout@master | ||
| - name: Set Xcode | ||
| run: | | ||
| echo "Available Xcode versions:" | ||
| ls /Applications | grep Xcode | ||
| echo "Choosing Xcode_${{ matrix.xcode }}.app" | ||
| sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode }}.app | ||
| xcodebuild -version | ||
| swift --version | ||
| swift package --version |
There was a problem hiding this comment.
They do the same thing, but DEVELOPER_DIR is slightly easier as it avoids us having to make a sudo call to xcode-select.
Happy to revert this if preferred though, I originally did it when I was debugging an issue as I thought it might have been related (it wasn't).
There was a problem hiding this comment.
No this is great, much better. I saw it recently too in https://github.com/yonaskolb/XcodeGen/pull/1374/files
liamnichols
changed the title
|
Thanks for the review @yonaskolb.. I just fixed the build error after i renamed a file in the last commit 🤦 |
I noticed that the CI checks only ran on Xcode 12 and 13 using macOS 11 so thought that it might be good to update this to have a sense-check using Xcode 14 as well.