adding support for enableGPUValidationMode #1294
Conversation
|
The tests are failing as the updated fixtures have not been committed. Just rerun the tests and commit the diffs. |
The Tests have finished. Please review this PR when you available. |
|
Just missed one comment above
And also while I notice, just a doc update at https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#common-build-action-options |
update Doc ProjectSpec.md
Done. |
Docs/ProjectSpec.md
Outdated
| @@ -933,6 +933,7 @@ The different actions share some properties: | |||
| - [ ] **postActions**: **[[Execution Action](#execution-action)]** - Scripts that are run *after* the action | |||
| - [ ] **environmentVariables**: **[[Environment Variable](#environment-variable)]** or **[String:String]** - `run`, `test` and `profile` actions can define the environment variables. When passing a dictionary, every key-value entry maps to a corresponding variable that is enabled. | |||
| - [ ] **enableGPUFrameCaptureMode**: **GPUFrameCaptureMode** - Property value set for `GPU Frame Capture`. Possible values are `autoEnabled`, `metal`, `openGL`, `disabled`. Default is `autoEnabled`. | |||
| - [ ] **enableGPUValidationMode**: **GPUValidationMode** - Property value set for `Metal API Validation`. Possible values are `enabled`, `disabled`, `extended`. Default is `enable`. | |||
There was a problem hiding this comment.
I notice the values and the default don't match here
There was a problem hiding this comment.
Thanks @LouisLWang. I will add the changelog entry on master for you
No description provided.