Skip to content

Commit

Permalink
Allow PHP >= 8.0 & Drop PHP < 7.3 (#26)
Browse files Browse the repository at this point in the history
* Allow PHP 8.x

* Drop support for PHP < 7.3
  • Loading branch information
phansys authored Apr 9, 2021
1 parent 37df160 commit 5f0f6bd
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 13 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
strategy:
matrix:
include:
- php-version: 7.1
- php-version: 7.3
symfony-version: 4.4.*
- php-version: 7.3
symfony-version: 5.2.*
- php-version: 7.4
symfony-version: 4.4.*
- php-version: 7.2
symfony-version: 5.1.*
- php-version: 7.4
symfony-version: 5.1.*
symfony-version: 5.2.*
- php-version: 8.0
symfony-version: 5.2.*

steps:
- name: "Checkout"
Expand All @@ -48,8 +48,8 @@ jobs:
strategy:
matrix:
include:
- php-version: 7.4
symfony-version: 5.1.*
- php-version: 8.0
symfony-version: 5.2.*

steps:
- name: "Checkout"
Expand All @@ -75,8 +75,8 @@ jobs:
strategy:
matrix:
include:
- php-version: 7.4
symfony-version: 5.1.*
- php-version: 8.0
symfony-version: 5.2.*

steps:
- name: "Checkout"
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
}
},
"require": {
"php": "^7.1",
"php": "^7.3|^8.0",
"sonata-project/admin-bundle": "^3.0",
"symfony/workflow": "^4.4|^5.0"
},
"require-dev": {
"phpunit/phpunit": "^7.5",
"phpunit/phpunit": "^8.5|^9.5",
"squizlabs/php_codesniffer": "^3.5"
}
}
4 changes: 3 additions & 1 deletion tests/Controller/WorkflowControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ class WorkflowControllerTest extends TestCase
*/
private $flashBag;

public function setUp()
protected function setUp(): void
{
parent::setUp();

$this->container = $this->prophesize(ContainerInterface::class);
$this->admin = $this->prophesize(AdminInterface::class);
$this->registry = new Registry();
Expand Down

0 comments on commit 5f0f6bd

Please sign in to comment.