Add release steps to the buildkite pipeline #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yob
commented
Jan 7, 2025
auto/release-gem
Outdated
| # gem build pdf-reader.gemspec | ||
| # GEM_HOST_API_KEY="${GEM_HOST_API_KEY}" gem push "pdf-reader-${RELEASE_VERSION}.gem" | ||
|
|
||
| docker run -it -v "${PWD}:/work" -w /work -e GEM_HOST_API_KEY="${GEM_HOST_API_KEY}" ruby:3.4-slim bash -c "gem build pdf-reader.gemspec && gem push \"pdf-reader-${RELEASE_VERSION}.gem\"" |
There was a problem hiding this comment.
I think we could go back to using the gem available in ubuntu's repositories, this was just be testing to see if the newer rubygems version helped.
yob
commented
Jan 7, 2025
.buildkite/pipeline.yml
Outdated
| - specs-legacy | ||
| - specs-jruby | ||
| - specs-jruby-soft | ||
| #branch: main |
yob
commented
Jan 7, 2025
auto/release-gem
Outdated
|
|
||
| echo "--- Request rubygems token" | ||
|
|
||
| RUBYGEMS_ROLE="rg_oidc_akr_xoy8sqmj25t8ok4rn5sq" |
There was a problem hiding this comment.
looks secret, but not actually that secret
yob
force-pushed
the
release-gem
branch
2 times, most recently
from
b64af5d to
1b631b5
Compare
yob
force-pushed
the
release-gem
branch
7 times, most recently
from
b13dcb1 to
f6b3db7
Compare
Aiming to release new gems from CI rather than manually * use plugin to fetch rubygems token via OIDC
|
Success! The blockers were sorted out, and v2.14.0 was successfully pushed from this branch: https://buildkite.com/yob-opensource/pdf-reader/builds/694/canvas I'll change the release steps to be main only, then merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noodling on some additional CI steps that will publish to rubygems.org from CI using OIDC, rather than me doing it manually from my laptop.
Partly blocked on rubygems/rubygems.org#5376, which I was able to work around but it makes the setup on rubygems.org difficult.
Hard blocked on rubygems/rubygems.org#5296 (comment), because rubygems.org recently started requiring OIDC tokens to have a
jticlaim and Buildkite doesn't include it (yet?).I also switched the pipeline.yml to DAG mode, because it's better.
I'm not using https://github.com/buildkite-plugins/rubygems-oidc-buildkite-plugin/ because it requires ruby in the CI env and I don't have it (and don't want to jump through hoops to install it)I'm now using it, with a branch that converts the plugin to bash