-
Notifications
You must be signed in to change notification settings - Fork 112
Fix visibility checks for global alerts. #2382
base: 9.x-2.x
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
ok to test |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3064/install.php Test PASSed. |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3064/ |
Open Y Complete profile installed at http://openy.cibox.tools/build3064/ |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
that automation thing is sometimes so overautomated.... |
Well... somehow after some changes this PR now contains more commits and more changes and doesn't apply to the place where it was applied without issues before... frustrating :( |
Fixed "frustration" by changing the base branch ^^ |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
5 similar comments
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
If alert is global then the $pages array ends up as [0 => ""] and can't be empty after the preg_split function.
Steps to review:
Conversation about this in Slack https://openy.slack.com/archives/C6G4ZTLVC/p1611132731028300