This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
remove unused deps #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraVieira
reviewed
Oct 19, 2017
package.json
Outdated
| "joyent-react-scripts": "^2.3.0", | ||
| "lint-staged": "^4.2.2", | ||
| "npm-run-all": "^4.1.1", |
There was a problem hiding this comment.
You can't remove this , its used for tests
SaraVieira
reviewed
Oct 20, 2017
package.json
Outdated
| "lint:css": "stylelint './src/**/*.js'", | ||
| "test": "run-s lint:js lint:css jest", | ||
| "jest": "jest --env=jsdom", | ||
| "build": "NODE_ENV=production bup", |
There was a problem hiding this comment.
Also build needs to be styleguidist build :(
It can be any other thing but let me know to update netlify
sergioramos
force-pushed
the
deps
branch
5 times, most recently
from
8d039e5
to
d4cce42
Compare
also: - bump version to 1.0.0 (easier to do semver that way) - add repository info - add builds for es, umd and iife - add prettier - use (almost) vanilla styleguidist - remove CONTRIBUTING (more relevant to the parent project )
SaraVieira
reviewed
Oct 20, 2017
| "fmt": "prettier --write --single-quote src/*.js", | ||
| "lint:js": "eslint . --fix", | ||
| "lint:css": "stylelint './src/**/*.js'", | ||
| "test": "run-s compile int:js lint:css jest", |
There was a problem hiding this comment.
there is an l missing ;(
|
what does bup do ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also: