Added the ability to prevent pan to close within the drawer. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow pan gestures to optionally pass through to the drawerViewController. Prevents e.g. swipe-to-delete on table view cells from being over-ridden to close the drawer.
Necessary to allow panToCloseInsideDrawerEnabled property to appear in Interface Builder.
This was referenced Feb 28, 2017
Update to latest upstream
|
@colincameron does this supersede #76? In other words, if we merge this in can we close #76? |
|
@timusus yes as far as I can remember this solves the same issue with some improvements. |
|
please merge this... |
Merge upstream changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panning to close was interfering with the ability to swipe to delete items in a table view within the drawer view controller, so I have added a property to prevent pan gestures being recognised if they are within the drawer.
This is similar to #76, but still allows panning to close outside the drawer.