Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date time fields support in crud form #501

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mohamed-nazim
Copy link
Contributor

@mohamed-nazim mohamed-nazim commented Apr 15, 2022

Updated my branch name for the previous PR and it ended up closed. So resubmitting.

This PR adds support for input field of type 'date', 'datetime' & 'time' in form/search fields and is based on current browser standards for date / date time input field. MDN definition for date says it uses YYYY-MM-DD standard and the definition for datetime-local uses YYYY-MM-DDT00:00 standard - which is what is sent over when the form is submitted (although what is rendered on the screen is based on local device settings/locale).

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Added input field of type 'date' and 'datetime' in form/search fields.
Added input field of type 'time' in form/search fields.
@WinterSilence
Copy link
Contributor

WinterSilence commented Apr 15, 2022

it's same to prev PR

where's your browsers and databases tests?

@mohamed-nazim
Copy link
Contributor Author

mohamed-nazim commented Apr 16, 2022

it's same to prev PR

where's your browsers and databases tests?

Yes @WinterSilence it's same (apart from the addition of time field handling). Prev PR got closed, because I messed up my branch name. See ☝️I said so at the beginning :)

browsers and databases tests - shall do and post asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants