Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #435: Fix incorrect classNames #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #435: Fix incorrect classNames #461

wants to merge 1 commit into from

Conversation

ditibal
Copy link

@ditibal ditibal commented Aug 5, 2021

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #435

@bizley bizley added the type:bug Bug label Aug 5, 2021
@bizley bizley added this to the 2.2.3 milestone Aug 5, 2021
@samdark samdark modified the milestones: 2.2.3, 2.2.4 Aug 9, 2021
@WinterSilence
Copy link
Contributor

WinterSilence commented Sep 24, 2021 •
edited
Loading

hmm.. you move patterns to end of list, what's changed?

@samdark
Copy link
Member

samdark commented Sep 24, 2021

@WinterSilence see issue linked.

@WinterSilence
Copy link
Contributor

WinterSilence commented Sep 24, 2021 •
edited
Loading

@samdark it's need fix, but use other way: current solution - BC, need add option to switch behavior

@samdark samdark removed this from the 2.2.4 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ditibal @WinterSilence @samdark @bizley