Add callback to Query::all() and Query::one()
#925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tigrov
commented
Jan 27, 2025
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues | yiisoft/data-db#50 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
============================================
- Coverage 99.62% 98.98% -0.65%
- Complexity 1500 1510 +10
============================================
Files 81 81
Lines 3710 3726 +16
============================================
- Hits 3696 3688 -8
- Misses 14 38 +24 ☔ View full report in Codecov by Sentry. |
samdark
requested changes
Jan 29, 2025
| @@ -115,6 +115,8 @@ Each table column has its own class in the `Yiisoft\Db\Schema\Column` namespace | |||
| ### New methods | |||
|
|
|||
| - `QuoterInterface::getRawTableName()` - returns the raw table name without quotes; | |||
| - `QueryInterface::callback()` - allows to use a callback, which should be called on each row of the query result; | |||
| - `QueryInterface::getCallback()` - returns the callback to be called on each row of the query result or `null` if not set; | |||
There was a problem hiding this comment.
Suggested change
| - `QueryInterface::getCallback()` - returns the callback to be called on each row of the query result or `null` if not set; | |
| - `QueryInterface::getCallback()` - returns the callback to be called on each row of the query result or `null` if the callback is not set; |
| @@ -250,6 +272,12 @@ public function batch(int $batchSize = 100): BatchQueryResultInterface | |||
| ; | |||
| } | |||
|
|
|||
| public function callback(Closure|null $callback): static | |||
There was a problem hiding this comment.
Need phpdoc with the callback signature.
| /** | ||
| * Sets callback, which should be called on each row of the query result. | ||
| * | ||
| * @psalm-param CallbackType|null $callback |
There was a problem hiding this comment.
Need to mention callback signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.