-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to change DB host and port for tests #286
base: master
Are you sure you want to change the base?
Conversation
vjik
commented
Jun 23, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | - |
PR Summary
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
=========================================
Coverage 99.67% 99.67%
Complexity 213 213
=========================================
Files 13 13
Lines 617 617
=========================================
Hits 615 615
Misses 2 2 ☔ View full report in Codecov by Sentry. |
What is the use case for this change, tests must be run with the default values. |
Usage two container for tests (PHP and DB) in one network. In this case I need change host to actual. |
This is not a problem with the package, it is a problem with your configuration. |
It's package problem that deny change host address. |
Imagine that each user, make a pr to adapt the package to its configuration, for me it should look like this, simple configuration. |
…ronment # Conflicts: # docs/en/testing.md
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
{ | ||
public static function getPostgreSqlHost(): string | ||
{ | ||
$host = getenv('YIISOFT_DB_PGSQL_TEST_HOST'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need use const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is necessary since that's the only place this string is used.