Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using evaluate internals #2353

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Avoid using evaluate internals #2353

merged 1 commit into from
Jul 8, 2024

Conversation

hadley
Copy link
Contributor

@hadley hadley commented Jul 8, 2024

In a few years, once this code is widespread in installed knitr, this will allow us to make some simplifications to evaluate

@hadley
Avoid using evaluate internals
c1ced74 
In a few years, once this code is widespread in installed knitr, this will allow us to make some simplifications to evaluate
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hadley hadley mentioned this pull request Jul 8, 2024
Merged
yihui
yihui approved these changes Jul 8, 2024
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yihui yihui merged commit 389382f into yihui:master Jul 8, 2024
10 checks passed
@hadley hadley deleted the evaluate-internals branch July 9, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadley @CLAassistant @yihui