Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sqlite Amalgamation #1522

Merged
merged 3 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/haskell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,4 @@ jobs:
- run: cabal v2-build all --disable-optimization $CONFIG
- run: cabal v2-test all --disable-optimization $CONFIG --test-options "--fail-on-focus"
- run: cabal v2-bench all --disable-optimization $CONFIG
- run: cabal v2-haddock all $CONFIG
continue-on-error: true
- run: cabal v2-sdist all
2 changes: 2 additions & 0 deletions persistent-sqlite/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* [#1486](https://github.com/yesodweb/persistent/pull/1486)
* Add Database.Sqlite.open' which takes a ByteString
* [#1522](https://github.com/yesodweb/persistent/pull/1522)
* Update the sqlite amalgamation to 3.43.1

## 2.13.2.0

Expand Down
4 changes: 3 additions & 1 deletion persistent-sqlite/Database/Sqlite.hs
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,9 @@ openError path' = do
open :: Text -> IO Connection
open path = open' (encodeUtf8 path)

-- @since 2.13.2.0
-- | Like 'open', but accepts a 'ByteString' instead of a 'Text'.
--
-- @since 2.13.3.0
open' :: BS.ByteString -> IO Connection
open' path = do
databaseOrError <- openError path
Expand Down
Loading
Loading