Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indentation rules for script and style tags #265

Conversation

FlorentinBouchendhomme
Copy link
Contributor

Issue Addressed

Fixes #264

Summary

Add the missing handling inside the file indent.js to manage the closing tags for script and style

Tests

Two tests added inside indent.test.js to verify:

  • if a valid </script> tag and </style> tag passes without errors
  • if an invalid </script> tag and </style> tag (with incorrect indentation e.g. two extra spaces) triggers errors

@FlorentinBouchendhomme FlorentinBouchendhomme changed the title Fix indentation rules for script and style tags fix: indentation rules for script and style tags Jan 16, 2025
@yeonjuan yeonjuan self-requested a review January 17, 2025 03:08
Copy link
Owner

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FlorentinBouchendhomme Thanks for the fix! LGTM 👍

@yeonjuan yeonjuan merged commit 444c711 into yeonjuan:main Jan 17, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[indent] indent of “</style>” and "</script>"
2 participants