templates

yeonjuan · Nov 30, 2024 · db4d1dd · db4d1dd
1 parent ebf5549
commit db4d1dd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/eslint-plugin/lib/rules/require-button-type.js b/packages/eslint-plugin/lib/rules/require-button-type.js
@@ -47,7 +47,10 @@ module.exports = {
             node: node.openStart,
             messageId: MESSAGE_IDS.MISSING,
           });
-        } else if (!VALID_BUTTON_TYPES_SET.has(typeAttr.value.value)) {
+        } else if (
+          !VALID_BUTTON_TYPES_SET.has(typeAttr.value.value) &&
+          !typeAttr.value.templates.length
+        ) {
           context.report({
             node: typeAttr,
             messageId: MESSAGE_IDS.INVALID,

diff --git a/packages/eslint-plugin/tests/rules/require-button-type.test.js b/packages/eslint-plugin/tests/rules/require-button-type.test.js
@@ -45,6 +45,9 @@ templateRuleTester.run("[template] require-button-type", rule, {
     {
       code: 'html`<button type="submit">Submit Button</button>`',
     },
+    {
+      code: 'html`<button type="${type}">Submit Button</button>`',
+    },
   ],
   invalid: [
     {
-Original file line number
+Diff line change
@@ Expand Up @@
         {
           code: 'html`<button type="submit">Submit Button</button>`',
         },
+        {
+          code: 'html`<button type="${type}">Submit Button</button>`',
+        },
       ],
       invalid: [
         {
@@ Expand Down @@