-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ycmd submodule #4259
Update ycmd submodule #4259
Conversation
Thanks! I was hoping to get ycm-core/ycmd#1752 merged before we update the ycmd submodude, but oh well. Meanwhile, I knew we'd have users hitting this gopls thing. Changelog since last update:
I've allowed CI on this pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
==========================================
+ Coverage 89.72% 89.85% +0.12%
==========================================
Files 37 37
Lines 4780 4780
==========================================
+ Hits 4289 4295 +6
+ Misses 491 485 -6 |
@msteffen Last night I've merged some things for C# and Java. Can you update the ycmd submodule again? |
@bstaletic done, just pushed! |
Thanks for the pull request! I'll be updating the README in a separate pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @msteffen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @msteffen)
Thanks for sending a PR! |
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
x
insidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
ycm-core/ycmd@master
contains a recent fix that updates its dependency ongopls
to the latest version, 0.16.1 (commit). Updating the submodule here ensures that users will get this fix and be using the latest version of gopls.As a contributor, I am opening this PR because the prior version of gopls that ycmd used, 0.15.3, contained a bug that is interrupting my workflow. Fortunately ycmd has already upgraded, so updating the submodule in YouCompleteMe is the only change that would be needed to fix it.
Thank you for your consideration!
This change is