Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ycmd submodule #4259

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update ycmd submodule #4259

merged 1 commit into from
Aug 27, 2024

Conversation

msteffen
Copy link
Contributor

@msteffen msteffen commented Aug 21, 2024

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

ycm-core/ycmd@master contains a recent fix that updates its dependency on gopls to the latest version, 0.16.1 (commit). Updating the submodule here ensures that users will get this fix and be using the latest version of gopls.

As a contributor, I am opening this PR because the prior version of gopls that ycmd used, 0.15.3, contained a bug that is interrupting my workflow. Fortunately ycmd has already upgraded, so updating the submodule in YouCompleteMe is the only change that would be needed to fix it.

Thank you for your consideration!


This change is Reviewable

@bstaletic
Copy link
Collaborator

Thanks!

I was hoping to get ycm-core/ycmd#1752 merged before we update the ycmd submodude, but oh well.
That pull request is stuck on getting C# to cooperate on windows.

Meanwhile, I knew we'd have users hitting this gopls thing.

Changelog since last update:

  • Abseil update, which should fix build errors on FreeBSD.
  • Automatically discovering the build tool path/version on Windows should work again.
  • Gopls update.
  • Preparing for moving C# to LSP

I've allowed CI on this pull request.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (0d85596) to head (7f0ef0e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4259      +/-   ##
==========================================
+ Coverage   89.72%   89.85%   +0.12%     
==========================================
  Files          37       37              
  Lines        4780     4780              
==========================================
+ Hits         4289     4295       +6     
+ Misses        491      485       -6     

@bstaletic
Copy link
Collaborator

@msteffen Last night I've merged some things for C# and Java. Can you update the ycmd submodule again?

@msteffen
Copy link
Contributor Author

@msteffen Last night I've merged some things for C# and Java. Can you update the ycmd submodule again?

@bstaletic done, just pushed!

@bstaletic
Copy link
Collaborator

Thanks for the pull request! I'll be updating the README in a separate pull request.

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Aug 27, 2024
Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @msteffen)

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 LGTMs obtained (waiting on @msteffen)

Copy link
Contributor

mergify bot commented Aug 27, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit b6e8c64 into ycm-core:master Aug 27, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants