Add CI + fix tests #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgeorge
commented
Aug 22, 2023
| second_single_beat.log \ | ||
| third_single_beat.log | ||
|
|
||
| (SINGLE_BEAT_REDIS_SERVER='redis://localhost:6379/9' SINGLE_BEAT_LOG_LEVEL=debug SINGLE_BEAT_IDENTIFIER='test-beat' python ../singlebeat/beat.py sh -c 'exec python long_waiting_process.py > first_single_beat.log') & |
There was a problem hiding this comment.
We must move the redirection into the command passed to single-beat so that the subprocess can flush its output. See #28
jonahgeorge
commented
Aug 22, 2023
| f = open(fname) | ||
| if "hello - " in f.read(): | ||
| hello_cnt += 1 | ||
| except OSError: |
There was a problem hiding this comment.
As the subprocess in test-single-beat.sh now handles the file redirection, the output for the processes which are not the leader will not create log files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #43
In attempting to run the Python unittest suite I discovered that it fails on Linux VMs; however, passes successfully on Darwin. This is a first draft to at least run this integration suite for each commit.
An example of it successfully passing can be seen in my fork:
https://github.com/jonahgeorge/single-beat/actions/runs/5943457084/job/16118643020
Future Improvements: