Configurable database names #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added POST to WebURL and PageFetcher. Included support for the new WebURL attributes in WebURLTupleBinding. I've suggested to deprecate newHttpUriRequest(String) in PageFetcher because it does not allow to pass post parameters.
DocIDServer is now aware of POST data and allows to visit the same URL if POST parameters are different. (Filling a form with different years, for instance). Suggested to deprecate getDocId, getNewDocID, addUrlAndDocId and isSeenBefore since they don't allow to pass post parameters. WebURL has the ability to encode itself into a single unique string. NOTE: This serialization SHOULD be improved.
The WebCrawler now passes the WebURL to the DocIDServer instead of passing a String URL. We assume GET on redirections. I'm not 100% sure if this is allways true. The case !curURL.getURL().equals(fetchResult.getFetchedUrl()) is still using old methods. Should be reviewed
Added addSeenUrl(WebURL) and addSeed(WebURL) methods to CrawlController. Did not touch original methods, although I'd suggest to make them create WebURLs and pass them to the new methods.
addSeed and addSeenUrl now will create a WebURL and pass it to the newly created methods. It will make it easier for the user to override those methods.
Suggedted to deprecate old fetchedUrl attribute and introduced fetchedWebUrl, which is a WebURL. Some tab style fixes.
There was a loop. Some style fixes.
It is possible to configure the database names from the CrawlControler constructor.
Extracted interfaces from Parser and PageFetcher in order to make it easier to create totally custom classes
|
why would we need to put them in the same working directory? |
Now WebURLs can be used as seeds, so we enforce docId to be < 0 unless staten otherwise
Post capabilities
Interfaces
|
Closed. I accidentaly merged other things into this branch. Opened #426 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to configure the database names from the CrawlControler constructor.
It allowed me to create multiple CrawlerControllers on the same working directory without having the URLs mixed between them.