Add an option to force capture of Jaeger traces #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the existing --jaeger flag adds trace, span and parent span information to outgoing RPCs. However it does not set the sampling bit, which means analysing the trace is impossible if the backend infrastructure is not recording the distributed trace. This new option --force-jaeger-sample ensures that every originating yab RPC is captured, most useful in the single yab (non benchmarking) case. It uses constSampler with a decision value of true to ensure the sampling bit in the Jaeger headers. See: https://www.jaegertracing.io/docs/1.22/client-libraries/#tracespan-identity
jronak
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the existing --jaeger flag adds trace, span and parent span information to outgoing RPCs.
However it does not set the sampling bit, which means analysing the trace is impossible if the backend infrastructure is not recording the distributed trace.
This new option --force-jaeger-sample ensures that every originating yab RPC is captured, most useful in the single yab (non benchmarking) case.
It uses constSampler with a decision value of true to ensure the sampling bit in the Jaeger headers. See:
https://www.jaegertracing.io/docs/1.22/client-libraries/#tracespan-identity