Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions): add typedoc plugin markdown as peer deps of typedoc #6659

Closed
wants to merge 1 commit into from

Conversation

njfamirm
Copy link

@njfamirm njfamirm commented Jan 21, 2025

What's the problem this PR addresses?

#6653

How did you fix it?

Read compatibility guide and comment in #6653
...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@njfamirm
Copy link
Author

The master branch builds failed ! so I can't fix bugs 🐛

@clemyan clemyan self-requested a review January 29, 2025 14:46
Copy link
Member

@clemyan clemyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem correct. A core package should not depend on plugins unless the plugin is "blessed". It doesn't seem like that is the case for typedoc-plugin-markdown upon a cursory glance.

@njfamirm
Copy link
Author

This does not seem correct. A core package should not depend on plugins unless the plugin is "blessed". It doesn't seem like that is the case for typedoc-plugin-markdown upon a cursory glance.

I just realized!
You're right.

@njfamirm njfamirm closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants