Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Some package want to use it's community driven plugin #6653

Closed
njfamirm opened this issue Jan 12, 2025 · 2 comments
Closed
Labels
waiting for feedback Will autoclose in a while unless more data are provided

Comments

@njfamirm
Copy link

I've looked at the docs resources you shared about compatibility.

My compatibility question is: Logically, a package shouldn't list community-created plugins as its own peerDependencies. A plugin depends on the core package, not the other way around.

Do these changes also need to be made to this file?

The issue was resolved using a package extension.

packageExtensions:
  "typedoc@*":
    peerDependencies:
      typedoc-plugin-markdown: "*"
@clemyan
Copy link
Member

clemyan commented Jan 14, 2025

Logically, a package shouldn't list community-created plugins as its own peerDependencies

Generally, yes. Unless that ecosystem has some "blessed" plugins that the core explicitly requires to function or the core itself provides additional functionality when a that plugin is install.

The issue was resolved using a package extension

What issue? Am I missing some context here?

@njfamirm
Copy link
Author

What issue? Am I missing some context here?

No, that's fine

@clemyan clemyan added the waiting for feedback Will autoclose in a while unless more data are provided label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Will autoclose in a while unless more data are provided
Projects
None yet
Development

No branches or pull requests

2 participants