chore: support multi-arch and prebuild binaries correctly #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yanyiwu @Mister-Hope review please as far as I am concerned, it is really heavy for a such simply node repo to use pnpm(it cause cannot support node<16) and rollup(it just has a ts file only, tsc or swc is enough) |
yeliex
changed the title
yeliex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr fix invalid configuration of github ci test and release, including support arm64 and run running in correctly arch os.
it should build pre-build binaries as expected and upload them to github node registry without specify token manually.
test case in my repo: https://github.com/yeliex/nodejieba/actions/runs/7206729058
EDIT: mark as draft currently because cannot build for arm64 directly, should use docker to support cross-compile