Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import project data from Drupal.org #33

Open
wants to merge 3 commits into
base: 8.x-3.x
Choose a base branch
from

Conversation

yanniboi
Copy link
Owner

This is to be able to have an autocomplete field for drupal project on the submission form.

@yanniboi
Copy link
Owner Author

selection_045

selection_043


selection_044

@yanniboi yanniboi force-pushed the feature/simplytest-import branch from edef901 to a13bf4d Compare May 17, 2017 15:53
@patrickd-
Copy link
Collaborator

  • i'd rather not commit the complete projects xml file as it will be outdated pretty quickly (it's also freaking 25MB big and that's a quite big, and it would still be in the git branchs history even if we remove it in a later commit... maybe start a new branch without it? hmm)
  • Looks like you ported the UI from the D7 module – unfortunately I had a design flaw in there that we shouldn't repeat if possible: https://www.drupal.org/node/2046297 – I can't quite remember the details, need to look into this..
  • Also I think there's been new APIs on drupal.org.. last time I checked they were rather badly documented but maybe there's a better way to fetch project data now; need to look into that too..
  • Project type determination (simplytest_projects_get_project_type) had also been problematic in the past – before d.o was ported to D7 (afaik) you could change the project type; but now you can't and people sometimes change the projects type in the repository but don't update the project type on the d.o project node. I'm not sure if there's a way around this or if we should just say... not our problem.
  • i know this is still wip but there are a couple of c&p method names (eg. getAddContactsFormRoute)

independently from the complicated issues that i already noticed in the d7 version I generally don't want that to be the reason holding back progress on this. we can figure that out at a later point, i'm pretty happy if we get a good foundation even if there are still legacy flaws.

@yanniboi
Copy link
Owner Author

I'll respond to your other points later, but for now:

The update XML file, don't worry about it being commited for now. It is in just for ease of development for now. I'm pretty sure there is a hardcoded path somewhere to /home/simplytest/www/... in there as well somewhere :p before any of this makes its way into HEAD, I'll remove those bits and make a squashed commit so that there is nothing in the git history.

@yanniboi
Copy link
Owner Author

Can you tell I'm tired by how often I said 'for now' :P

@patrickd-
Copy link
Collaborator

Might be related: https://www.drupal.org/node/2081551

@yanniboi
Copy link
Owner Author

yanniboi commented May 18, 2017

Drupal.org restws is good, but it doesn't really have a lot of things that we need...

Maybe we should file issues to have git tags/project releases and statistics added to the rest endpoint. It would also be good it we could make api requests based on the project short name rather than having to do a whole other lookup just to get node ID.

I spoke to @andrewbelcher today and he pointed out to me that we can look up available tags/releases in composer as well so that might be another thing to co sider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants