Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to theme export #57

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

odendayoko
Copy link
Member

@odendayoko odendayoko commented Oct 26, 2024

Closes #47

Description

Add ability to theme export as zip

New behavior

Export saved theme as zip like this
darkTheme1 (11).zip

Is this a breaking change (Yes/No):

No

Additional Information

  • Implementation of importing themes will be handled separately.
  • ESLint configuration changes have caused warnings in past implementations of indexedDB.I ignored the ESLint warning once because the implementation needed to be modified in order to resolve it.I will raise it in an Issue and correct it.Sorry...😢

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yamada-theme ❌ Failed (Inspect) Oct 26, 2024 4:16am

@odendayoko odendayoko changed the base branch from main to dev October 26, 2024 04:16
Comment on lines +34 to +42
"@yamada-ui/calendar": "^1.8.1",
"@yamada-ui/carousel": "^2.0.6",
"@yamada-ui/charts": "^1.5.3",
"@yamada-ui/dropzone": "^1.0.45",
"@yamada-ui/fontawesome": "^1.0.41",
"@yamada-ui/lucide": "^1.6.0",
"@yamada-ui/markdown": "^1.0.44",
"@yamada-ui/react": "^1.5.3",
"@yamada-ui/table": "^1.2.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change. It is downgrad.

@@ -28,17 +28,19 @@
"@emotion/cache": "^11.13.0",
"@emotion/react": "^11.13.0",
"@emotion/weak-memoize": "^0.4.0",
"@types/file-saver": "^2.0.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move devDependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not diable lint rule. You are told that this conditional statement is useless.
It is unnecessary or the type is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to export and import theme
2 participants