Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiex(sql): fixed sql.Scanner/driver.Valuer support in BitBool/shardid.ID #16

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

cnlangzi
Copy link
Member

Fixes

  • fixed sql.Scanner/driver.Valuer support in BitBool/shardid.ID

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.85%. Comparing base (e740b30) to head (2adb541).

Files Patch % Lines
shardid/id.go 76.47% 2 Missing and 2 partials ⚠️
bitbool.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   66.81%   67.85%   +1.03%     
==========================================
  Files          29       30       +1     
  Lines        1100     1120      +20     
==========================================
+ Hits          735      760      +25     
+ Misses        284      276       -8     
- Partials       81       84       +3     
Flag Coverage Δ
Unit-Tests 67.85% <86.11%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnlangzi cnlangzi merged commit ed9994d into main Feb 27, 2024
2 checks passed
@cnlangzi cnlangzi deleted the fix/id_scaner_valuer branch February 27, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants