-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supervisor Resource capability configuration #64
base: master
Are you sure you want to change the base?
Conversation
Keep track of the running supervisors within the StormAMRMClient. Make use of this list and the yarn blacklist feature to ensure that multiple supervisors do not allocate on the same node.
The supervisor resource size is now configurable through the storm-yarn configuration
@@ -63,7 +63,7 @@ | |||
</repositories> | |||
<properties> | |||
<storm.version>0.9.0-wip21</storm.version> | |||
<hadoop.version>2.1.0-beta</hadoop.version> | |||
<hadoop.version>2.2.0</hadoop.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this requires Hadoop 2.2 then we probably want to find the correct version of CDH and HDP that also work with it and update them accordingly. (Just because people are going to ask for it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. HDP seems to be at 2.2.0.2.1.0.0-92.
CDH on the other hand seems to be on a SNAPSHOT? Wasn't sure: (https://repository.cloudera.com/artifactory/cloudera-repos/org/apache/hadoop/hadoop-common/)
I did a quick look through the code and for the most part it looks good. I had a few comments but nothing too terribly serious. Before I can merge anything in I am going to need you to read over https://github.com/yahoo/storm-yarn/wiki/Contributing and send a signed copy of the CLA to the email address listed there. We need to come up with a much better integration testing for storm-yarn, probably something using the Hadoop mini cluster, but for now I would look into doing some unit tests. I kind of feel bad asking you to unit test code that doesn't have any real unit tests to start out with. If you could look at finding a good point to mock out the RM interactions that would be great. That might take moving to the AsyncClient for that. If it is too much of a pain to come up with if you could make sure you run some manual tests and show the result that would probably be enough. |
Yeah I can do that, I'll try to get the CLA back to you soon. And get the modifications to the pull request in quickly. As per mocking/unit testing, do you have any preferences? I usually like JMockit, but am open to anything. |
For mocking storm currently uses Mockito 1.9.5. We hope to keep the door open so that this project can merge into storm proper at some point relatively soon. So if you could use that it would be great. |
Includes:
Notes:
Thanks