SonarJS including deprecated rule

packages/eslint-config-flat/src/index.ts

@@ -4,6 +4,7 @@ import { importConfig } from './import/index.ts'
 // import { markdownConfig } from './markdown/index.ts'
 // import { prettierConfig } from './prettier/index.ts'
 import { rulesConfig } from './rules/index.ts'
+import { sonarConfig } from './sonar/index.ts'
 // import { sonarConfig } from './sonar/index.ts'
 import { typescriptConfig } from './typescript/index.ts'
 import { unicornConfig } from './unicorn/index.ts'
@@ -17,7 +18,7 @@ export const config: Linter.Config[] = [
   rulesConfig,
   // prettierConfig,
   importConfig,
-  // sonarConfig
+  sonarConfig,
 ]
 
 export { importConfig } from './import/index.ts'

packages/eslint-config-flat/src/markdown/index.ts

@@ -1,7 +1,7 @@
 import type { ESLint, Linter } from 'eslint'
 import mdPlugin from 'eslint-plugin-md'
 
-export const markdownConfig: Linter.FlatConfig = {
+export const markdownConfig: Linter.Config = {
   ignores: ['.yarn/**', 'jest.config.cjs', '**/dist/**', 'dist', 'build/**', 'node_modules/**'],
   files: ['*.md'],
   processor: 'md/markdown',

packages/eslint-config-flat/src/rules/index.ts

@@ -1,6 +1,6 @@
 import type { Linter } from 'eslint'
 
-export const rulesConfig: Linter.FlatConfig = {
+export const rulesConfig: Linter.Config = {
   ignores: ['.yarn/**', 'jest.config.cjs', '**/dist/**', 'dist', 'build/**', 'node_modules/**'],
   rules: {
     'complexity': ['error', 18],

packages/eslint-config-flat/src/sonar/index.ts

@@ -1,11 +1,21 @@
 import type { Linter } from 'eslint'
 import sonarjsPlugin from 'eslint-plugin-sonarjs'
 
+const { rules, ...recommended } = sonarjsPlugin.configs.recommended
+
 export const sonarConfig: Linter.Config = {
   ignores: ['.yarn/**', 'jest.config.cjs', '**/dist/**', 'dist', 'build/**', 'node_modules/**'],
-  ...sonarjsPlugin.configs,
+  ...recommended,
   rules: {
-    ...sonarjsPlugin.configs.recommended.rules,
+    ...rules,
     'sonarjs/no-small-switch': ['off'],
+    'sonarjs/os-command': ['off'],
+    'sonarjs/no-os-command-from-path': ['off'],
+    'sonarjs/no-nested-conditional': ['off'],
+    'sonarjs/todo-tag': ['warn'],
+    'sonarjs/deprecation': ['warn'],
+    'sonarjs/cognitive-complexity': ['warn'],
+    'sonarjs/no-nested-functions': ['off'],
+    'sonarjs/function-return-type': ['warn'],
   },
 }

packages/eslint-config-flat/src/unicorn/index.ts

@@ -1,7 +1,7 @@
 import type { ESLint, Linter } from 'eslint'
 import unicornPlugin from 'eslint-plugin-unicorn'
 
-export const unicornConfig: Linter.FlatConfig = {
+export const unicornConfig: Linter.Config = {
   ignores: ['.yarn/**', 'jest.config.cjs', '**/dist/**', 'dist', 'build/**', 'node_modules/**'],
   plugins: { unicorn: unicornPlugin as ESLint.Plugin },
   rules: {

packages/eslint-config-flat/src/workspaces/index.ts

@@ -1,7 +1,7 @@
 import type { ESLint, Linter } from 'eslint'
 import workspacesPlugin from 'eslint-plugin-workspaces'
 
-export const workspacesConfig: Linter.FlatConfig = {
+export const workspacesConfig: Linter.Config = {
   ignores: ['.yarn/**', 'jest.config.cjs', '**/dist/**', 'dist', 'build/**', 'node_modules/**'],
   plugins: { workspaces: workspacesPlugin as ESLint.Plugin },
   rules: {

packages/ts-scripts-yarn3/src/actions/license.ts

@@ -49,11 +49,11 @@ export const license = async (pkg?: string) => {
                   for (let license of licenses) {
                     if (license) {
                       // remove surrounding parens on some string
-                      if (license[0] === '(' && license.at(-1) === ')') {
-                        license = license.slice(1, -2)
-                      }
+                      const processedLicense = (license[0] === '(' && license.at(-1) === ')')
+                        ? license.slice(1, -2)
+                        : license
                       // get list of OR licenses from string
-                      const orLicenses = license.split(' OR ')
+                      const orLicenses = processedLicense.split(' OR ')
                       let orLicenseFound = false
                       for (const orLicense of orLicenses) {
                         if (exclude.has(orLicense)) {

packages/ts-scripts-yarn3/src/actions/lint-clean.ts

@@ -3,7 +3,7 @@ import { rmSync } from 'node:fs'
 import { yarnWorkspaces } from '../lib/index.ts'
 import { lint } from './lint.ts'
 
-export const lintClean = () => {
+export const lintClean = async () => {
   console.log('Lint Clean [.eslintcache]')
   const workspaces = yarnWorkspaces()
   const result = workspaces
@@ -20,5 +20,5 @@ export const lintClean = () => {
     })
     // eslint-disable-next-line unicorn/no-array-reduce
     .reduce((prev, result) => prev || result, 0)
-  return result || lint()
+  return result || await lint()
 }

packages/ts-scripts-yarn3/src/actions/package/clean-outputs.ts

@@ -4,13 +4,15 @@ import chalk from 'chalk'
 
 import { deleteGlob } from '../../lib/index.ts'
 
-export const packageCleanOutputs = async () => {
+export const packageCleanOutputs = () => {
   const pkg = process.env.INIT_CWD ?? '.'
   const pkgName = process.env.npm_package_name
   const folders: string[] = [path.join(pkg, 'dist'), path.join(pkg, 'build'), path.join(pkg, 'docs')]
   console.log(chalk.green(`Cleaning Outputs [${pkgName}]`))
 
-  await Promise.all(folders.map(folder => deleteGlob(folder)))
+  for (let folder of folders) {
+    deleteGlob(folder)
+  }
 
   return 0
 }

packages/ts-scripts-yarn3/src/actions/package/clean-typescript.ts

@@ -4,13 +4,15 @@ import chalk from 'chalk'
 
 import { deleteGlob } from '../../lib/index.ts'
 
-export const packageCleanTypescript = async () => {
+export const packageCleanTypescript = () => {
   const pkg = process.env.INIT_CWD ?? '.'
   const pkgName = process.env.npm_package_name
   console.log(chalk.green(`Cleaning Typescript [${pkgName}]`))
   const files: string[] = [path.join(pkg, '*.tsbuildinfo'), path.join(pkg, '.tsconfig.*'), path.join(pkg, '.eslintcache')]
 
-  await Promise.all(files.map(file => deleteGlob(file)))
+  for (let file of files) {
+    deleteGlob(file)
+  }
 
   return 0
 }

packages/ts-scripts-yarn3/src/lib/generateIgnoreFiles.ts

@@ -6,7 +6,9 @@ import {
   INIT_CWD, yarnWorkspace, yarnWorkspaces,
 } from './yarn/index.ts'
 
-const mergeEntries = (a: string[], b: string[]): string[] => [...union(a, b)].sort()
+const localeCompare = (a: string, b: string) => a.localeCompare(b)
+
+const mergeEntries = (a: string[], b: string[]): string[] => [...union(a, b)].sort(localeCompare)
 
 export const generateIgnoreFiles = (filename: string, pkg?: string) => {
   console.log(chalk.green(`Generate ${filename} Files`))

packages/ts-scripts-yarn3/src/lib/withError.ts

@@ -2,7 +2,7 @@ export const withError = <T extends Error = Error>(
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   ex: any,
   closure: (error: T) => number,
-  predicate = (ex: T) => ex.name !== undefined && ex.message !== undefined,
+  predicate = (ex: T) => (!!ex.name && !!ex.message),
 ) => {
   return predicate(ex as T) ? closure(ex as T) : undefined
 }