Move lambda opt-out logic to IsInTestMethod extension method since it…

…'s always desired

src/xunit.analyzers/Utility/CodeAnalysisExtensions.cs

@@ -84,6 +84,8 @@ public static bool IsInTestMethod(
 
 		for (var parent = operation.Parent; parent is not null; parent = parent.Parent)
 		{
+			if (parent is IAnonymousFunctionOperation or ILocalFunctionOperation)
+				return false;
 			if (parent is not IMethodBodyOperation methodBodyOperation)
 				continue;
 			if (methodBodyOperation.Syntax is not MethodDeclarationSyntax methodSyntax)

src/xunit.analyzers/X1000/DoNotUseBlockingTaskOperations.cs

@@ -154,11 +154,6 @@ invocation.Arguments[0].Value is IArrayCreationOperation arrayCreationOperation
 			if (!foundSymbol)
 				return;
 
-			// Ignore anything inside a lambda expression or a local function
-			for (var current = context.Operation; current is not null; current = current.Parent)
-				if (current is IAnonymousFunctionOperation or ILocalFunctionOperation)
-					return;
-
 			if (foundSymbolName == nameof(Task<int>.Result) &&
 					reference.Instance is ILocalReferenceOperation localReferenceOperation &&
 					TaskIsKnownToBeCompleted(reference, [localReferenceOperation.Local], taskType, xunitContext))

src/xunit.analyzers/X1000/DoNotUseConfigureAwait.cs

@@ -63,11 +63,6 @@ public override void AnalyzeCompilation(
 			if (!invocation.IsInTestMethod(xunitContext))
 				return;
 
-			// Ignore anything inside a lambda expression or a local function
-			for (var current = context.Operation; current is not null; current = current.Parent)
-				if (current is IAnonymousFunctionOperation or ILocalFunctionOperation)
-					return;
-
 			// invocation should be two nodes: "(some other code).ConfigureAwait" and the arguments (like "(false)")
 			var invocationChildren = invocation.Syntax.ChildNodes().ToList();
 			if (invocationChildren.Count != 2)

src/xunit.analyzers/X1000/UseCancellationToken.cs

@@ -35,11 +35,6 @@ public override void AnalyzeCompilation(
 			if (!invocationOperation.IsInTestMethod(xunitContext))
 				return;
 
-			// Ignore anything inside a lambda expression or a local function
-			for (var current = context.Operation; current is not null; current = current.Parent)
-				if (current is IAnonymousFunctionOperation or ILocalFunctionOperation)
-					return;
-
 			var invokedMethod = invocationOperation.TargetMethod;
 			var parameters = invokedMethod.Parameters;