Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Oracle FREE DB #565

Merged
merged 2 commits into from
May 23, 2024
Merged

Added Oracle FREE DB #565

merged 2 commits into from
May 23, 2024

Conversation

liborfuka
Copy link
Contributor

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@OndrejGerzicak
Copy link

I don't get purpose of this OracleFREE builder? There is already OracleXE builder. The only difference I can see between those two is the default DB_NAME, but that should be possible to set with a parameter in constructor. If the constructor isn't enough for you feel free to add another that suits you, but I don't think it necessary to create a new class in this case. Am I missing something?

@liborfuka
Copy link
Contributor Author

There are two differences - DATA_DIR and DB_NAME. Yes It should be solved by adding new constructor but there are two different products:
Oracle Database Express Edition (our class OracleXE)
Oracle Database Free

Ok, how to finally solve it?
Create new constructor in OracleXE class?

@OndrejGerzicak
Copy link

Ok missed the DATA_DIR, sorry for that. As it's two different product maybe you are right that there should be separate classes. But to avoid the code duplicity, you could create some base Oracle DB class and inherit the common code for the product explicit classes from there?

@liborfuka
Copy link
Contributor Author

Ok, I will create AbstractOracle class.

@liborfuka
Copy link
Contributor Author

I added OracleAbstract class. DATA_DIR /opt/oracle/oradata is the same in the latest Oracle DB images: container-registry.oracle.com/database/express:latest and container-registry.oracle.com/database/free:latest

Copy link

@OndrejGerzicak OndrejGerzicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@mnovak
Copy link
Contributor

mnovak commented May 23, 2024

LGTM, merging.

@mnovak mnovak merged commit a9b8abf into xtf-cz:master May 23, 2024
0 of 2 checks passed
@mnovak
Copy link
Contributor

mnovak commented May 30, 2024

I've found that changing DATA_DIR to /opt/oracle/oradata starting of Oracle takes significatly longer (from seconds to 10+ minutes). I'll return it back to /var/lib/oracle/data. @liborfuka could you check what this change will do with Oracle FREE DB?

@liborfuka
Copy link
Contributor Author

Hi @mnovak1

Oracle data files are stored in /opt/oracle/oradata in Oracle DB images. If you change it to something else it starts faster but you can not test with physical volume claims and you can not test these test scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants