-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Oracle FREE DB #565
Added Oracle FREE DB #565
Conversation
I don't get purpose of this OracleFREE builder? There is already OracleXE builder. The only difference I can see between those two is the default DB_NAME, but that should be possible to set with a parameter in constructor. If the constructor isn't enough for you feel free to add another that suits you, but I don't think it necessary to create a new class in this case. Am I missing something? |
There are two differences - DATA_DIR and DB_NAME. Yes It should be solved by adding new constructor but there are two different products: Ok, how to finally solve it? |
Ok missed the DATA_DIR, sorry for that. As it's two different product maybe you are right that there should be separate classes. But to avoid the code duplicity, you could create some base Oracle DB class and inherit the common code for the product explicit classes from there? |
Ok, I will create AbstractOracle class. |
I added OracleAbstract class. DATA_DIR /opt/oracle/oradata is the same in the latest Oracle DB images: container-registry.oracle.com/database/express:latest and container-registry.oracle.com/database/free:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you
LGTM, merging. |
I've found that changing DATA_DIR to |
Hi @mnovak1 Oracle data files are stored in /opt/oracle/oradata in Oracle DB images. If you change it to something else it starts faster but you can not test with physical volume claims and you can not test these test scenarios. |
Please make sure your PR meets the following requirements: