Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward integration test exit code to running proc #5180

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 4, 2024

Fixes #5179

@Tyriar Tyriar added this to the 6.0.0 milestone Oct 4, 2024
@Tyriar Tyriar self-assigned this Oct 4, 2024
@Tyriar Tyriar enabled auto-merge October 4, 2024 03:10
@Tyriar Tyriar mentioned this pull request Oct 4, 2024
4 tasks
@jerch
Copy link
Member

jerch commented Oct 4, 2024

@Tyriar Was able to fix the dispose error. The other errors are all timeout errors and happen at different occasions. Locally all runs fine, idk why the integration tests are this flaky in the CI env. It is really annoying if the CI is that unreliable.

@Tyriar Tyriar merged commit a5fc111 into xtermjs:master Oct 4, 2024
12 checks passed
@jerch jerch mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests are failing but the action isn't reporting failure
2 participants