Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include base/ platform from VS Code, adopt DomScrollableElement and introduce esbuild #5077

Closed
wants to merge 41 commits into from

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 2, 2024

Succeeds #5076

@Tyriar Tyriar added this to the 5.6.0 milestone Jul 2, 2024
@Tyriar Tyriar self-assigned this Jul 2, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 3, 2024

I stopped this briefly to work on some debt and to bring some of the changes here into main in smaller PRs. Doing some tables to better understand where we want to go:

Here is the current main output usage:

Use Path Format Runtime Note
Demo (/ and /test) demo/dist/client-bundle.js bundle browser Used in API/playwright tests
  out/ tsc - Used for core and addons
Unit tests out/ tsc node.js Running in a real browser would be nice
API tests out-test/api/ tsc node.js Removed in #5080
Integration tests out-test/playwright/ tsc node.js
Benchmark out-test/benchmark/ tsc node.js
@xterm/xterm package lib/xterm.js bundle browser
@xterm/headless package headless/lib-headless/xterm-headless.js bundle node.js

And the current output usage on this branch (I think):

Use Path Format Runtime Note
Demo (/ and /test) demo/dist/client-bundle.js bundle browser Used in API/playwright tests
  out-tsc/ tsc - Used for image addon only
  out-esbuild/ esbuild - Used for ligatures addon only
  lib/ esbuild - Used for core and other addons (this might require packaging atm?)
Unit tests out-tsc/ tsc node.js Running in a real browser would be nice
API tests out-tsc/test-api/ tsc node.js
Integration tests out-tsc/test-playwright/ tsc node.js
Benchmark out-tsc/test-benchmark/ tsc node.js
@xterm/xterm package lib/xterm.js bundle browser
@xterm/headless package headless/lib-headless/xterm-headless.js bundle node.js

@Tyriar
Copy link
Member Author

Tyriar commented Jul 3, 2024

main:

image

Proposal (probably needs a different PR):

image

@jerch
Copy link
Member

jerch commented Jul 9, 2024

@Tyriar Plz just ping me, if you think this is ready to have a look from my side. Seems there are still some merge conflicts from your ESM transition, and I dont want to interfere in the middle of that transition to not over-complicate things.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 9, 2024

@jerch yep planning on closing and redoing this PR today, the next one will be significantly smaller (ignoring base/) since esbuild was added in the other PR

@Tyriar
Copy link
Member Author

Tyriar commented Jul 9, 2024

Closing in favor of #5096

@Tyriar Tyriar closed this Jul 9, 2024
@Tyriar Tyriar modified the milestones: 5.6.0, 6.0.0 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants