-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search is very slow when there is a lot of content and many wrapped lines #4902
Comments
Does the perf only degrade for wrapped lines? So the same amount of data on wrapped lines is just fine? |
This cost is not small either. |
@tisilent My first guess here is, that overlong lines take really long during the regexp matching, at least this was in the past a big issue. If its caused by that, than we prolly cant do much about it beside using really big guns like non-blocking search within a separate worker thread. |
Full scrollback with long non-wrapped lines seemed fine on my machine, only when I wrapped them did it slow down. |
Normal on xterm demo, slightly lagging in vscode. |
Here is a Bash version:
For a generic Posix shell replace the first line with the following (tested with zsh):
|
Without having looked too deeply into the issue, it seems plausible that #4928 may help, as the LineBuffer data structure represents logical (unwrapped) lines. Of course some API tweaks may be needed. |
Repro:
Run the following script in powershell and try search:
The text was updated successfully, but these errors were encountered: