Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching in terminal with large scrollback and many wrapped lines is slow #152548

Open
AurevoirXavier opened this issue Jun 18, 2022 · 2 comments
Open

Searching in terminal with large scrollback and many wrapped lines is slow #152548

AurevoirXavier opened this issue Jun 18, 2022 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities perf terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
Backlog

Comments

@AurevoirXavier
Copy link

AurevoirXavier commented Jun 18, 2022 •
edited
Loading

Might be similar to #147685.

macOS: 12.4 (21F79)
code:

Version: 1.68.1 (Universal)
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-14T12:52:13.188Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin arm64 21.5.0

Around 2 million characters.
But extremely fast on my native terminal.

a.mov
@meganrogge meganrogge added terminal-search bug Issue identified by VS Code Team member as probable bug perf labels Jun 20, 2022
@meganrogge meganrogge added this to the Backlog milestone Jun 20, 2022
@Tyriar Tyriar added terminal-find Relating the terminal's find widget and removed terminal-search labels Dec 7, 2022
@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2023

I can still reproduce this, it happens only with a lot of large wrapped lines

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 7, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2023

Upstream xtermjs/xterm.js#4902

@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities upstream-issue-linked This is an upstream issue that has been reported upstream labels Dec 7, 2023
@Tyriar Tyriar changed the title Searching in terminal with large scrollback is slow on macOS Searching in terminal with large scrollback and many wrapped lines is slow Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities perf terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@Tyriar @AurevoirXavier @meganrogge