Merge pull request #4787 from Tyriar/pw_tweak

Tweak playwright workers
xtermjs · Sep 10, 2023 · b2c123e · b2c123e
2 parents be82ffc + efcca3f
commit b2c123e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -259,12 +259,12 @@ jobs:
         ls -R
     - name: Build demo
       run: yarn build-demo
-    - name: Integration tests (core)
-      run: yarn test-playwright-${{ matrix.browser }} --forbid-only --workers 4 --suite=core
+    - name: Integration tests (core) # Tests use 50% workers to reduce flakiness
+      run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=core
     - name: Integration tests (xterm-addon-canvas)
-      run: yarn test-playwright-${{ matrix.browser }} --forbid-only --workers 4 --suite=xterm-addon-canvas
+      run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=xterm-addon-canvas
     - name: Integration tests (xterm-addon-webgl)
-      run: yarn test-playwright-${{ matrix.browser }} --forbid-only --workers 4 --suite=xterm-addon-webgl
+      run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=xterm-addon-webgl
 
   test-api:
     needs: build

diff --git a/bin/test_playwright.js b/bin/test_playwright.js
@@ -35,7 +35,7 @@ function npmBinScript(script) {
 async function run() {
   for (const config of configs) {
     const command = npmBinScript('playwright');
-    const args = ['test', '-c', config.path, ...argv.slice(2)];
+    const args = ['test', '-c', config.path, ...argv];
     console.log(`Running suite \x1b[1;34m${config.name}...\x1b[0m`);
     console.log(`\n\x1b[32m${command}\x1b[0m`, args);
     const run = cp.spawnSync(command, args, {

diff --git a/package.json b/package.json
@@ -38,11 +38,11 @@
     "test-api-chromium": "node ./bin/test_api.js --browser=chromium --timeout=20000",
     "test-api-firefox": "node ./bin/test_api.js --browser=firefox --timeout=20000",
     "test-api-webkit": "node ./bin/test_api.js --browser=webkit --timeout=20000",
-    "test-playwright": "node ./bin/test_playwright.js --workers 4",
-    "test-playwright-chromium": "node ./bin/test_playwright.js --workers 4 \"--project=Chrome Stable\"",
-    "test-playwright-firefox": "node ./bin/test_playwright.js --workers 4 \"--project=Firefox Stable\"",
-    "test-playwright-webkit": "node ./bin/test_playwright.js --workers 4 \"--project=WebKit\"",
-    "test-playwright-debug": "node ./bin/test_playwright.js --headed --workers 1 --timeout 30000",
+    "test-playwright": "node ./bin/test_playwright.js --workers=75%",
+    "test-playwright-chromium": "node ./bin/test_playwright.js --workers=75% \"--project=Chrome Stable\"",
+    "test-playwright-firefox": "node ./bin/test_playwright.js --workers=75% \"--project=Firefox Stable\"",
+    "test-playwright-webkit": "node ./bin/test_playwright.js --workers=75% \"--project=WebKit\"",
+    "test-playwright-debug": "node ./bin/test_playwright.js  --workers=1 --headed --timeout=30000",
     "test-unit": "node ./bin/test.js",
     "test-unit-coverage": "node ./bin/test.js --coverage",
     "test-unit-dev": "cross-env NODE_PATH='./out' mocha",