Tweak tsc

xtermjs · Aug 20, 2023 · 9da4816 · 9da4816
1 parent 2ee61b7
commit 9da4816
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,8 +22,8 @@ jobs:
       run: |
         tsc -b addons/xterm-addon-image/src/tsconfig.json
         yarn esbuild
-    - name: Build
-      run: yarn setup
+    - name: Check types # TODO: This could be its own job
+      run: yarn check-types
     - name: Zip artifacts
       run: |
         zip -r compressed-build \

diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -20,7 +20,7 @@
     {
       "label": "watch-types",
       "type": "npm",
-      "script": "watch",
+      "script": "watch-types",
       "group": "build",
       "isBackground": true,
       "problemMatcher": "$tsc-watch",

diff --git a/package.json b/package.json
@@ -52,11 +52,15 @@
     "benchmark-eval": "NODE_PATH=./out xterm-benchmark -r 5 -c test/benchmark/benchmark.json --eval out-test/benchmark/test/benchmark/*benchmark.js",
     "clean": "rm -rf lib out addons/*/lib addons/*/out",
     "vtfeatures": "node bin/extract_vtfeatures.js src/**/*.ts src/*.ts",
+
     "esbuild": "node bin/esbuild_all.mjs",
     "esbuild-dev": "node bin/esbuild_all.mjs --dev",
     "esbuild-dev-watch": "node bin/esbuild_all.mjs --dev --watch",
     "esbuild-demo": "node bin/esbuild.mjs --demo-client",
-    "esbuild-demo-watch": "node bin/esbuild.mjs --demo-client --watch"
+    "esbuild-demo-watch": "node bin/esbuild.mjs --demo-client --watch",
+
+    "check-types": "tsc -b ./tsconfig.all.json --emitDeclarationOnly",
+    "watch-types": "tsc -w -b ./tsconfig.all.json --emitDeclarationOnly"
   },
   "devDependencies": {
     "@types/chai": "^4.2.22",