Skip to content

BufferLine rewrite [WIP] #891

BufferLine rewrite [WIP]

BufferLine rewrite [WIP] #891

Triggered via pull request September 21, 2024 00:14
Status Failure
Total duration 6m 6s
Artifacts 1

ci.yml

on: pull_request
Matrix: test-integration
Matrix: test-unit
test-unit-coverage
1m 1s
test-unit-coverage
Matrix: release-dry-run
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 19 warnings
lint
Process completed with exit code 1.
test-unit (18, macos)
Process completed with exit code 75.
test-unit (18, windows)
The job was canceled because "_18_macos" failed.
test-unit (18, windows)
The operation was canceled.
test-unit (18, ubuntu)
The job was canceled because "_18_macos" failed.
test-unit (18, ubuntu)
The operation was canceled.
test-unit-coverage
Process completed with exit code 75.
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: src/common/InputHandler.test.ts#L455
Variable name `a_repeat_cols` must match one of the following formats: camelCase, UPPER_CASE
lint: src/common/InputHandler.ts#L534
Missing semicolon
lint: src/common/InputHandler.ts#L1227
Expected @param names to be "row, respectProtect". Got "y"
lint: src/common/buffer/Buffer.ts#L410
Split 'let' declarations into multiple statements
lint: src/common/buffer/Buffer.ts#L914
Missing semicolon
lint: src/common/buffer/BufferLine.ts#L37
Missing accessibility modifier on class property _isWrapped
lint: src/common/buffer/BufferLine.ts#L88
Missing accessibility modifier on method definition get
lint: src/common/buffer/BufferLine.ts#L134
Missing accessibility modifier on method definition setCellFromCodepoint
lint: src/common/buffer/BufferLine.ts#L152
Missing accessibility modifier on method definition deleteCells
lint: src/common/buffer/BufferLine.ts#L185
Unexpected var, use let or const instead
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-unit (18, macos)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, NathanFirmo/[email protected], actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-unit-coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
release-dry-run (18)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-integration (18, ubuntu, chromium)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, NathanFirmo/[email protected], actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-integration (18, ubuntu, firefox)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, NathanFirmo/[email protected], actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "build-artifacts". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
test-integration (18, ubuntu, webkit)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, NathanFirmo/[email protected], actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Artifacts

Produced during runtime
Name Size
build-artifacts
4.3 MB