Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started working on new plugin remake #23

Merged
merged 9 commits into from
Aug 12, 2023
Merged

Started working on new plugin remake #23

merged 9 commits into from
Aug 12, 2023

Conversation

notangelmario
Copy link
Collaborator

@notangelmario notangelmario commented Aug 7, 2023

Well, time to revive this project!

Fresh has finally implemented the ability for plugins to create routes, so this makes
implementing fresh-seo look less like it's built with duct tape.

In my opinion we should keep the old functionality for backwards compatibility.

Other things to do:

  • Remove the import from the deno.json and put it in deps.ts (I put it there temporarily)
  • Implement glob matching in removing routes (see Remove routes #22 )
  • Add route options to include option
  • Remove functionality to create setup in the old style

@notangelmario notangelmario added the enhancement New feature or request label Aug 7, 2023
@notangelmario notangelmario requested review from sinyo-matu and xstevenyung and removed request for sinyo-matu August 10, 2023 10:31
Copy link
Collaborator

@sinyo-matu sinyo-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notangelmario awesome work!
It runs really smoothly with my Fresh website.
And I think this really makes it effortless!

Here are my comments.
If you have any questions, just let me know.

src/plugin.ts Outdated Show resolved Hide resolved
src/plugin.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sinyo-matu sinyo-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think we should delete createSitemap related codes located

await createSitemap(url);

because user have got the /sitemap.xls route provided by our plugin

@notangelmario
Copy link
Collaborator Author

Oh yeah, I should've created the pull request as a draft but it is what it is.

include and exclude should also be an array of routes and options of those routes.

And yeah, the init process should be removed, but it shouldn't interfere with old setups.

@notangelmario
Copy link
Collaborator Author

Alright I think it's pretty much done. Anything to add?

Copy link
Collaborator

@sinyo-matu sinyo-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notangelmario
A big Thank you sir!

@xstevenyung
Copy link
Owner

lfg! thx for the update, excited to finally have the plugin api implemented

@xstevenyung xstevenyung merged commit 15e9427 into main Aug 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants