-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started working on new plugin remake #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notangelmario awesome work!
It runs really smoothly with my Fresh website.
And I think this really makes it effortless!
Here are my comments.
If you have any questions, just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I think we should delete createSitemap related codes located
Line 86 in d3cc04b
await createSitemap(url); |
because user have got the
/sitemap.xls
route provided by our plugin
Oh yeah, I should've created the pull request as a draft but it is what it is.
And yeah, the init process should be removed, but it shouldn't interfere with old setups. |
Co-authored-by: sinyo-matu <[email protected]>
Co-authored-by: sinyo-matu <[email protected]>
Alright I think it's pretty much done. Anything to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notangelmario
A big Thank you sir!
lfg! thx for the update, excited to finally have the plugin api implemented |
Well, time to revive this project!
Fresh has finally implemented the ability for plugins to create routes, so this makes
implementing
fresh-seo
look less like it's built with duct tape.In my opinion we should keep the old functionality for backwards compatibility.
Other things to do:
deno.json
and put it indeps.ts
(I put it there temporarily)include
option