Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed name from instrument and its dependencies #498

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Removed name from instrument and its dependencies #498

merged 1 commit into from
Dec 16, 2024

Conversation

lmauviard
Copy link
Collaborator

I removed the name parameter from the Instrument init which cause the merging of the scaling factor into the instrument to break if no name parameter was given.

@lmauviard lmauviard requested review from thjsal and sguillot December 16, 2024 16:30
@lmauviard lmauviard linked an issue Dec 16, 2024 that may be closed by this pull request
Instrument init may break merging of scaling factor #497
Closed
thjsal
thjsal approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@thjsal thjsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also double checked that this solves the same error for me too, and the notebooks plotting arfs are working.

@lmauviard lmauviard merged commit acca794 into main Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjsal thjsal thjsal approved these changes

@sguillot sguillot Awaiting requested review from sguillot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrument init may break merging of scaling factor
2 participants
@lmauviard @thjsal