-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create switch size option #26
base: master
Are you sure you want to change the base?
Conversation
I like the idea, but wouldn't it be better to use a class - like "sm" or "lg" to create this behaviour? a bit more bootstrappy... |
Any progress on this PR? Would love to have it! |
@iJungleboy @evdoks - I am a little confused. Do you two just want a class of "sm" and "lg" or something more along the lines of "switchery-sm" and "switchery-lg"? |
My suggestion is just to add the class "sm" or "lg" - so you might have a class="green sm" and it would do both. |
@xpepermint This is ready to be reviewed and merged to the master branch. |
@EskoCruz that's awesome 👍 |
I think it'd be better if you make that "size" attribute an integer so that I'm able to have many different sizes to choose instead of just 3 (small, medium or large). |
Here is a solution for issue #25 by @tomerb15.
I created an attribute of "size" that have the options of "small" or "large".
By using:
size="small"
orsize="large"
This will change the size of the switch.