Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create switch size option #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

EskoCruz
Copy link

@EskoCruz EskoCruz commented Oct 8, 2015

Here is a solution for issue #25 by @tomerb15.
I created an attribute of "size" that have the options of "small" or "large".
By using:
size="small" or size="large"
This will change the size of the switch.

image

@iJungleboy
Copy link

I like the idea, but wouldn't it be better to use a class - like "sm" or "lg" to create this behaviour? a bit more bootstrappy...

@evdoks
Copy link

evdoks commented Nov 4, 2015

Any progress on this PR? Would love to have it!

@EskoCruz
Copy link
Author

EskoCruz commented Nov 4, 2015

@iJungleboy @evdoks - I am a little confused. Do you two just want a class of "sm" and "lg" or something more along the lines of "switchery-sm" and "switchery-lg"?
class="switchery-sm"
I may have this just about written out now, just need to verify before checking in this PR. 👍

@iJungleboy
Copy link

My suggestion is just to add the class "sm" or "lg" - so you might have a class="green sm" and it would do both.

@EskoCruz
Copy link
Author

EskoCruz commented Dec 4, 2015

@xpepermint This is ready to be reviewed and merged to the master branch.

@iJungleboy
Copy link

@EskoCruz that's awesome 👍
I hope @xpepermint will find time to go through the pulls soon :)

@yagotome
Copy link

yagotome commented Mar 5, 2017

I think it'd be better if you make that "size" attribute an integer so that I'm able to have many different sizes to choose instead of just 3 (small, medium or large).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants