Fix "Implicitly marking parameter $prompt as nullable is deprecated"

Fixes #346
xp-framework · Dec 30, 2024 · dead44e · dead44e
1 parent 1c924c0
commit dead44e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -3,6 +3,12 @@ XP Framework Core ChangeLog
 
 ## ?.?.? / ????-??-??
 
+### Bugfixes
+
+* Fixed *Implicitly marking parameter $prompt as nullable is deprecated*
+  warnings in `util.cmd.Console` class with PHP 8.4, fixing #346.
+  (@thekid)
+
 ### Features
 
 * Merged PR #345: Support passing floating point numbers to constructor,

diff --git a/src/main/php/util/cmd/Console.class.php b/src/main/php/util/cmd/Console.class.php
@@ -106,21 +106,21 @@ public static function writeLinef($format, ... $args) {
    * Read a line from standard input. The line ending (\r and/or \n)
    * is trimmed off the end.
    *
-   * @param  string $prompt Optional prompt
+   * @param  ?string $prompt Optional prompt
    * @return string
    */    
-  public static function readLine(string $prompt= null) {
+  public static function readLine($prompt= null) {
     $prompt && self::$out->write($prompt.' ');
     return self::$in->readLine();
   }
 
   /**
    * Read a single character from standard input.
    *
-   * @param  string $prompt Optional prompt
+   * @param  ?string $prompt Optional prompt
    * @return string
    */    
-  public static function read(string $prompt= null) {
+  public static function read($prompt= null) {
     $prompt && self::$out->write($prompt.' ');
     return self::$in->read(1);
   }