-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement property hooks syntax #45
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8285409
Implement property hooks syntax
thekid a60ac68
Wrap hooks in lang.ast.nodes.Hook
thekid d420291
Omit leading `$` from field name
thekid 9a6891e
Add full parameter syntax support
thekid 90a74a1
Add support for final hooks
thekid 527e9cd
Add holder to hooks
thekid 590c67a
Add abbreviated form for `get` hooks
thekid 34a779b
Support abstract hooks
thekid 4490d7e
Remove support for variadic and by-ref hook parameters
thekid bb9f4de
Consistently use "property" for properties
thekid 9f261c6
Make Node::children() return by reference, enabling replacement
thekid 54392db
Add support for by-ref hooks, e.g. `&get`
thekid 639cff8
MFH 10.1.0-RELEASE
thekid 08adb69
MFH
thekid 0e57d4a
MFH
thekid 256d717
Merge branch 'feature/property-hooks' of github.com:xp-framework/ast …
thekid 858951a
Merge branch 'master' into feature/property-hooks
thekid deb3329
Merge branch 'master' into feature/property-hooks
thekid 33d6f86
Remove abstract hooks, they are no longer included in the RFC
thekid 6bfe8c0
Simplify abstract property test
thekid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not adding this as constructor parameter partly in order to prevent a BC break, partly because of how parsing works.