Revoke Installation #38
Conversation
yeah definitely still missing tests! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 78.94% 77.32% -1.63%
==========================================
Files 9 10 +1
Lines 114 172 +58
==========================================
+ Hits 90 133 +43
- Misses 24 39 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This all looks good. Sorry it took me so long to get back to this as I was fighting some integration test issues today. It turns out that this change breaks the production deployment. I think that is in part my fault since I didn't add the production build to the ci.
I'll create a ticket and assign it to you.
| /// * `name` - the name of the contact bundle variant | ||
| /// * `value` - the value of the contact bundle | ||
| /// * `signature` - the signature of the contact bundle | ||
| #[method(name = "revokeInstallation")] |
| pub const SERVER_HOST: &str = "127.0.0.1"; | ||
|
|
||
| #[cfg(test)] | ||
| mod it { |
There was a problem hiding this comment.
This change loses the it module? That is how I am excluding the anvil tests in the pages build.
There was a problem hiding this comment.
ah, I can add it back, I was just adding integration tests that were longer, and wanted to remove some of the indentation, didn't realize it was tied to the gh pages build
Closes #21
Has a companion xmtp/didethresolver#35 , to add the logic of signing attributes/delegates/owners
changes the
nameparameter of the RPC to aXmtpAttribute, which is able to convert between the string representation of the attribute ("xmtp/installation/hex") and the byte[u8; 32]representation, which is taken directly fromlib_didethresolverso that if the library type changes, it will be evident in the gateway via compilation error.Other misc changes: