Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc missing properties and type fixes #86

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

dmccartney
Copy link
Contributor

@dmccartney dmccartney commented Aug 16, 2023

This fixes a pile of bugs/missing fields (coming from partners exploring SDK integrations).

Here's the hit-list:

  • Conversation is missing .createdAt and .context.metadata
  • listBatchMessages is ignoring pageSize on iOS
  • DecodedMessage is missing contentTypeId
  • DecodedMessage is missing topic
    • ... from conversation.messages
    • ... from conversation.streamMessages
    • ... from listBatchMessages (future PR, requires xmtp-ios and xmtp-android fixes)
    • ... from streamAllMessages (future PR, requires xmtp-ios and xmtp-android fixes)

Along the way this also:

  • adds a bunch of tests around adapting message and conversation types
  • formalizes some of the JSON generation in the native code
  • reduces the imprint of conversationId to merely part of the context (i.e. topic alone can identify the conversation)

@dmccartney dmccartney marked this pull request as ready for review August 16, 2023 21:24
@dmccartney dmccartney requested a review from a team as a code owner August 16, 2023 21:24
@dmccartney dmccartney merged commit 630af81 into main Aug 20, 2023
2 of 3 checks passed
@dmccartney dmccartney deleted the daniel-shape-fixes branch August 20, 2023 05:40
@github-actions
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants