Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support App Version #79

Merged
merged 12 commits into from
Jul 26, 2023
Merged

Support App Version #79

merged 12 commits into from
Jul 26, 2023

Conversation

nplasterer
Copy link
Contributor

This is a breaking change

This reworks the way we are doing client options currently by allowing an object to be passed instead. This will make it easier for us to allow more options and brings it more inline with how js does it.

closes: #7

@nplasterer nplasterer self-assigned this Jul 25, 2023
@nplasterer nplasterer marked this pull request as ready for review July 26, 2023 01:48
@nplasterer nplasterer requested review from jhaaaa and a team as code owners July 26, 2023 01:48
Copy link
Contributor

@dmccartney dmccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG (after isSecure note addressed)

ios/XMTPModule.swift Outdated Show resolved Hide resolved
@nplasterer nplasterer merged commit 37f28f1 into main Jul 26, 2023
1 check failed
@nplasterer nplasterer deleted the np/app-version branch July 26, 2023 19:30
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more ClientOptions
2 participants