Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to remove usage docs and link to them instead #531

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

jhaaaa
Copy link
Contributor

@jhaaaa jhaaaa commented Nov 12, 2024

No description provided.

@jhaaaa jhaaaa requested a review from a team as a code owner November 12, 2024 21:03
@@ -64,326 +67,20 @@ yarn add @xmtp/react-native-sdk

### Configure for iOS

In the `ios` directory, update your `Podfile` file as follows:
1. In the `ios` directory, update your `Podfile` file to set this value: `platform :ios, '16.0'`. This is required by XMTP.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the flow in this section correct? Just making sure I structured it correctly. TY!


Access the `xmtp-react-native` client SDK [reference documentation](https://xmtp.github.io/xmtp-react-native/modules.html).
Access the [XMTP React Native SDK reference documentation](https://xmtp.github.io/xmtp-react-native/modules.html).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you spot-check these to see if these are building as expected, please? TY!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep look good!


Access the `xmtp-react-native` client SDK [reference documentation](https://xmtp.github.io/xmtp-react-native/modules.html).
Access the [XMTP React Native SDK reference documentation](https://xmtp.github.io/xmtp-react-native/modules.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep look good!

@nplasterer nplasterer merged commit a245c2e into main Nov 13, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the readme-rm-doc branch November 13, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants