Bug streaming groups multi client #496
Conversation
|
Does not reproduce in Android proper. Only reproduces in iOS and Android inside of ReactNative. Makes me think it's an event listener issue. |
|
All the other methods already had this check so everything should work now. 🙏 |
| } | ||
|
|
||
| return true | ||
| }) |
There was a problem hiding this comment.
@nmalzieu I think this fix also fixed this weird bug? Can you confirm?
|
| @@ -146,7 +146,7 @@ export default class Conversations< | |||
| const groupsSubscription = XMTPModule.emitter.addListener( | |||
| EventTypes.Group, | |||
| async ({ inboxId, group }: { inboxId: string; group: GroupParams }) => { | |||
| if (this.known[group.id]) { | |||
| if (this.known[group.id] || this.client.inboxId !== inboxId) { | |||
There was a problem hiding this comment.
I think this is a good fix to merge now.
long term, I wonder if it would be a worthwhile performance gain to programmatically generate these Expo Module events to include the inbox-id in their name, so we dont send copies of all clients' events to each client event listener and then need to filter them out.
There was a problem hiding this comment.
I looked into that and it didn't seem straight forward. But something we should consider looking into again for sure.
|
🎉 This PR is included in version 2.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #495