fix: syncAllGroups returns num of groups synced. possible fork fixes #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting that for some reason on android RN, the first syncAllGroups after being removed reflects the new number of groups the user is in, while on android native, ios native, and ios RN, one sync is required after removal from a group, before it to be reflected in the numActive groups. This inconsistency should not affect any core behavior and isnt worth holding up the rest of the fixes and updates in this release, so I recommend we move ahead and look into that behavior inconsistency in a different thread. |
neekolas
approved these changes
Aug 26, 2024
alexrisch
approved these changes
Aug 26, 2024
|
🎉 This PR is included in version 2.4.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.