Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: correction typos #449

Merged
merged 2 commits into from
Aug 8, 2024
Merged

chore: correction typos #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36c39ac
chore: correction typo packaging_notes.md
osrm Jul 28, 2024
5ee8048
chore: correction typo README.md
osrm Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ First create a free account and download your client id from https://thirdweb.co
cd example
cp EXAMPLE.env .env
```
Finally, insert yout Thirdweb client id in specified location of `example/.env` file:
Finally, insert your Thirdweb client id in specified location of `example/.env` file:
```
THIRD_WEB_CLIENT_ID=INSERT_CLIENT_ID_HERE
```
Expand Down Expand Up @@ -53,4 +53,4 @@ Running tests locally is useful when updating GitHub actions, or locally testing
5. You can stop the XMTP server with the following command:
```bash
docker-compose -p xmtp -f dev/local/docker-compose.yml down
```
```
2 changes: 1 addition & 1 deletion packaging_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ These are the same SDKs that native iOS or Android apps would use, but are wrapp
|-> executes as part of Gradle build
|-> finds @xmtp/react-native-sdk/expo-module.config.json
|-> Resolves reference to `org.xmtp.android`
|-> This is an artifact published from `xmtp-android` (canonical Android XMTP SDK, used by Android projects direclty)
|-> This is an artifact published from `xmtp-android` (canonical Android XMTP SDK, used by Android projects directly)
|-> Gradle finds `org.xmtp.android` in whatever repositories are configured (Maven, etc)
|-> Fetches `org.xmtp.android` jar files and metadata
|-> Finishes Android-specific module setup
Expand Down
Loading