Decouple message store from waku #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snormore
force-pushed
the
decouple-store
branch
from
dc77a74
to
c5fefb8
Compare
neekolas
reviewed
Sep 3, 2023
snormore
force-pushed
the
decouple-store
branch
2 times, most recently
from
4a32a34
to
bdc0aab
Compare
snormore
force-pushed
the
decouple-store
branch
4 times, most recently
from
38cf6fe
to
c0f65d5
Compare
neekolas
approved these changes
Sep 11, 2023
snormore
force-pushed
the
decouple-store
branch
from
c0f65d5
to
4c0ed05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull over some message store cleanup from #295 that decouples it from waku. This should also make it much easier to upgrade the go-waku dependency. Functionally everything should be the same, since we were already writing to the store in the API service on publish, with our custom store, and not relying on the waku store protocol directly. The PR also removes unused waku filter and lightpush code.